NVIDIA-RTX / NVIDIA-RTX/Streamline

Validate Bidirectional distortion Field Texture

Open
#63 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ack documentation
Dominant language
C
Stars
1.2k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

Hi,

The documentation describes being able to provide a bidirectional distortion field but it's not entirely clear what space it should be.

The documentation says this:

Units: the buffer values should be in normalized pixel space [0,1].

But the contents of the buffer describe the relative offset of the UV coordinates after being distorted, so this can be negative?
While the code snippet contains this, which contradicts the doc

// The output can be outside of the [0, 1] range
Texture2D[UV] = float4(rg, ba); // needs to be **signed**

Also this:

These should be the same scale as the input MVecs

Is this the scale of the data in the motion vector texture before or after being scaled by sl::Constants::mvecScale?

Given that there are no tools to see what the distortion texture is doing with the other inputs, it's very hard to verify the correctness of the distortion texture.
The debug view in the ImGui plugin shows that all the inputs (eg. Motion/Depth) are unaffected by the distortion texture. So again, hard to validate.

Any futher details would be helpful.

Thanks,
Simon

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the documentation passages about normalized pixel space, signed output, input MVec scale, and sl::Constants::mvecScale, then compare them with the shown HLSL snippet. Inspect the ImGui plugin debug view described in the issue to determine what can be observed. Done means the expected distortion-texture space and scaling relationship are unambiguous and the validation limitations are documented.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics, documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.