NVIDIA-RTX / NVIDIA-RTX/Streamline
NIS Sharpening is broken on DirectX 11
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.2k
- Forks
- 159
- PR merge metrics
- No merged PRs in 30d
Description
Since updating Streamline to the latest version, the NIS plugin does not work correctly. Sometimes it works, sometimes it doesn't.
No errors will be reported by NIS. slEvaluateFeature will return sl::Result::eOk but no sharpening is applied.
Calling
sl::NISOptions nisOptions{};
nisOptions.mode = sl::NISMode::eSharpen;
nisOptions.hdrMode = sl::NISHDR::eNone;
nisOptions.sharpness = a_sharpness;
if (SL_FAILED(result, slNISSetOptions(viewport, nisOptions))) {
logger::critical("[Streamline] Could not set NIS options");
}
Returns no errors either.
Probably unrelated to this bug report but the latest Streamline might have major performance issues as well, based on reports from many users of reduced performance since updating.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the DirectX 11 behavior around slEvaluateFeature and slNISSetOptions with the shown NIS options, then trace the Streamline NIS path used by DirectX 11. Compare successful and unsuccessful runs, including the reported eOk results. Done means sharpening is applied consistently without errors in the affected path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100