NVIDIA-RTX / NVIDIA-RTX/Streamline

C++23 issue

Open Beginner friendly
#111 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug triaged
Dominant language
C
Stars
1.2k
Forks
159
PR merge metrics
No merged PRs in 30d

Description

https://github.com/NVIDIA-RTX/Streamline/blob/019994e18d256a3e92347888deb527feb7f58bc0/include/sl_pcl.h#L91

Hello,

When testing locally with C++23 enabled, we found we had to slightly modify sc_pcl.h. We now include <utility>, modified the preprocessor conditional, and changed the referenced lines to:

#if __cplusplus >= 202302L
using std::to_underlying;
#else

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at include/sl_pcl.h around line 91 and compare the C++23 compatibility changes described in the issue, including the include and preprocessor conditional. Verify the change with a C++23-enabled build; done means the file compiles without the local modifications reported by the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.