FusedResampling.hlsl:68~74, redundant visible light sample check?
Open
Nobody has claimed this yet.
- Dominant language
- HLSL
- Stars
- 545
- Forks
- 100
- Avg merge
- 14d 6h
- Merged PRs (30d)
- 1
Description
RTXDI_SampleLightsForSurface include visible light sample check by cast a shadow ray to check occlusion with scene BVH, after the function returns,
WRS reservioir include visibility information, so additional check will be redundant and pay more workload.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in FusedResampling.hlsl around lines 68–74 and trace the RTXDI_SampleLightsForSurface call and the WRS reservoir visibility data it returns. Confirm whether the later visible-light check duplicates that information and measure the effect of changing it; done means the redundancy question is resolved with supporting results.
Written by the indexing model from the issue text.
Assessment
- Domain
- computer-graphics, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100