NVIDIA-NeMo / NVIDIA-NeMo/Run

@run.cli.entrypoint(skip_confirmation=True) has no effect — confirmation prompt still shown

Open Beginner friendly
#608 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

community-request waiting-on-maintainers
Dominant language
Python
Stars
258
Forks
113
Avg merge
1d 3h
Merged PRs (30d)
5

Description

Description

The documented skip_confirmation parameter of @run.cli.entrypoint ("If True, skips user confirmation before execution") is stored on the Entrypoint object but never consumed when the CLI command is built. Every non-dryrun invocation still prompts Continue? [y/N] unless the user additionally passes --yes/-y or run.skip_confirmation=True.

Steps to reproduce
# app.py
import nemo_run as run

@run.cli.entrypoint(skip_confirmation=True)
def hello(name: str = "world"):
    print(f"hello {name}")

if __name__ == "__main__":
    run.cli.main(hello)
$ python app.py name=test
...
Continue? [y/N]:
Expected behavior

With skip_confirmation=True on the entrypoint the command runs without prompting (same as --yes).

Actual behavior

The prompt still appears. Entrypoint.skip_confirmation is dead — _add_executor_command never forwards it to RunContext.cli_command, so the generated command's skip_confirmation option keeps its False default.

Fwiw the repo's own tests work around this: test/cli/test_api.py declares entrypoints with skip_confirmation=True yet passes run.skip_confirmation=True / --yes when invoking them.

Environment

nemo-run main (b85eb67), Python 3.12, macOS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at _add_executor_command and follow how it builds the command through RunContext.cli_command; the issue identifies Entrypoint.skip_confirmation as the missing value. Review test/cli/test_api.py and add or adjust coverage for an entrypoint using skip_confirmation=True without run.skip_confirmation or --yes. Done means the documented decorator option runs a non-dryrun command without displaying the confirmation prompt.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.