NVIDIA-NeMo / NVIDIA-NeMo/RL

Coverage report for `nemo_rl/distributed/model_utils.py` is incorrect

Open
#928 0 comments 0 reactions 0 assignees View on GitHub
bug CI Infra testing
Dominant language
Python
Stars
2k
Forks
561
Avg merge
4d 5h
Merged PRs (30d)
145

Description

**Describe the bug**

For a coverage report like https://app.codecov.io/gh/NVIDIA-NeMo/RL/blob/main/nemo_rl%2Fdistributed%2Fmodel_utils.py , only the function signatures are marked as covered (i.e., green), while the statements of the function are marked as uncovered (red). In reality, those statements should be marked as covered.

**Steps/Code to reproduce bug**

Run a L1 CI run and check out the coverage report.

**Expected behavior**

The statements within each function should be marked as covered; maybe not all of the statements, but definitely shouldn't be zero.

**Environment overview (please complete the following information)**

**Environment details**

**Additional context**

Discovered while working on https://github.com/NVIDIA-NeMo/RL/pull/918/checks?check_run_id=48136029019
Corresponding coverage report:
https://app.codecov.io/gh/NVIDIA-NeMo/RL/pull/918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=NVIDIA-NeMo

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.