NVIDIA-NeMo / NVIDIA-NeMo/Gym

Refactor Global config dict top level keys into a pydantic object

Open
#684 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Config
Dominant language
Python
Stars
1.2k
Forks
349
Avg merge
1d 21h
Merged PRs (30d)
318

Description

This is too much https://github.com/NVIDIA-NeMo/Gym/blob/f19769acb63f9155c7c1ed3e10304955862da8e2/nemo_gym/global_config.py#L45
Let's put into a Pydantic model and just model validate

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read nemo_gym/global_config.py around line 45 and trace how the global config dict is constructed and consumed. Define a Pydantic model for the existing top-level keys and switch validation to it; done when the configuration uses the validated object instead of the current dict handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.