NVIDIA-NeMo / NVIDIA-NeMo/Gym

JSON decoding exception during global config dict loading

Open
#545 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Config
Dominant language
Python
Stars
1.2k
Forks
349
Avg merge
1d 21h
Merged PRs (30d)
318

Description

Describe the bug

This usage of json.loads during global config dict yaml loading can fail with a json decoding exception:

https://github.com/NVIDIA-NeMo/Gym/blob/main/nemo_gym/server_utils.py#L221

Steps/Code to reproduce bug

Please list minimal steps or code snippet for us to be able to reproduce the bug.

A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.

Expected behavior

A clear and concise description of what you expected to happen.

Configs
NeMo Gym (e.g. via ng_dump_config) or RL training framework config files.

Environment details

Otherwise, please provide:

  • OS version
  • Python version
  • uv pip list output

Additional context

Add any other context about the problem here.
Example: GPU model

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in nemo_gym/server_utils.py around line 221 and inspect how json.loads is used while loading the global config dictionary from YAML. Reproduce the reported decoding exception with a NeMo Gym or RL training configuration, then define the expected handling from the existing config-loading behavior and verify that valid configurations still load successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.