NVIDIA-NeMo / NVIDIA-NeMo/Guardrails

[Feature Request] Bedrock Embedding model

Open
#139 9 comments 0 reactions 1 assignee View on GitHub

@drazvan is already working on this.

Since Oct 5, 2023.

enhancement good first issue status: help wanted
Dominant language
Python
Stars
7.2k
Forks
842
Avg merge
3d 1h
Merged PRs (30d)
25

Description

Hi, Bedrock has a couple of embedding models, in particular, "amazon.titan-embed-g1-text-02". I'd like to submit a feature request so that I can use this model:

models:
  - type: embeddings
    engine: amazon_bedrock
    parameters:
      model_id: "amazon.titan-embed-text-v1"

I think this file needs to be updated?
https://github.com/NVIDIA/NeMo-Guardrails/blob/5f2541edb3e1115d48fc219e6e4d287d2d759ca1/nemoguardrails/embeddings/basic.py

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.