NVIDIA-NeMo / NVIDIA-NeMo/DataDesigner
Add other common params to ChatCompletionInferenceParams
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 2.2k
- Forks
- 211
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 40
Description
Priority Level
Medium (Nice to have)
Is your feature request related to a problem? Please describe.
We currently only support top_p and temperature
Describe the solution you'd like
support others:
top_k, min_p, presence_penalty, repetition_penalty
Describe alternatives you've considered
Currently there's a workaround to pass these via extra_body
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the definition and handling of ChatCompletionInferenceParams, then compare how top_p and temperature are represented and forwarded. Add support for top_k, min_p, presence_penalty, and repetition_penalty alongside them, and verify that callers no longer need to pass these values through extra_body.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100