NVIDIA-NeMo / NVIDIA-NeMo/Curator

Revisit limit behavior for FilePartitioningStage

Open
#948 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement ray-api
Dominant language
Python
Stars
1.8k
Forks
328
Avg merge
4d 5h
Merged PRs (30d)
30

Description

Is your feature request related to a problem? Please describe.
Currently in FilePartitioningStage , if we provide limit we just drop other tasks, dont think we should do that.

https://github.com/NVIDIA-NeMo/Curator/blob/5dc3166e8251ec6ee803154a860b1a7818e199d5/ray-curator/ray_curator/stages/file_partitioning.py#L96-L99

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ray-curator/ray_curator/stages/file_partitioning.py, especially the limit handling around lines 96-99, and trace how FilePartitioningStage selects and discards tasks. Clarify the intended limit behavior and validate it against the stage's existing tests or execution path; done means the chosen behavior is explicit and no longer silently drops tasks unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.