NVIDIA-NeMo / NVIDIA-NeMo/Curator
Explore performance degradation from reading parquet files file by file
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 328
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 30
Description
Is your feature request related to a problem? Please describe.
We were historically doing pd.read_parquet(list_of_files) but now have moved to pd.concat((pd.read_parquet(f) for f in files)).
https://github.com/NVIDIA-NeMo/Curator/pull/1249/files#r2546234214
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the parquet-reading call sites and compare the historical pd.read_parquet(list_of_files) approach with pd.concat((pd.read_parquet(f) for f in files)); add a focused benchmark or test that captures the performance difference. Done means the degradation is characterized and a clear implementation direction is recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- pandas, python
- Domain
- data-engineering, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100