make check reports many type failures

Open

#201 opened on Jun 30, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

task

Dominant language: Python
Stars: 122
Forks: 17
Avg merge: 4d 2h
Merged PRs (30d): 11

Description

Priority Level

Medium

Task Summary

The PR template suggests that make check should pass locally. However, on a fresh clone of the repo plus make install, running make check does exit with a 0 status code but reports 230 ty error diagnostics.

Technical Details & Implementation Plan

Some of these seem like potentially repo and/or [ty-]environment setup issues. For example:

error[unknown-argument]: Argument `task_status` does not match any known parameter
   --> tests/test_telemetry.py:228:17
    |
226 |             AnonymizerEvent(
227 |                 task=TaskEnum.BATCH,
228 |                 task_status=TaskStatusEnum.COMPLETED,
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
229 |                 transformation_type="redact",
230 |             )
    |
info: rule `unknown-argument` is enabled by default

error[unknown-argument]: Argument `transformation_type` does not match any known parameter
   --> tests/test_telemetry.py:229:17
    |
227 |                 task=TaskEnum.BATCH,
228 |                 task_status=TaskStatusEnum.COMPLETED,
229 |                 transformation_type="redact",
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
230 |             )
    |
info: rule `unknown-argument` is enabled by default

These seem reasonable given the AnonymizerEvent pydantic definition (see task_status and transformation_type).

Dependencies

No response

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Run make install followed by make check and inspect the reported diagnostics, starting with tests/test_telemetry.py and the AnonymizerEvent definition in src/anonymizer/telemetry.py. Trace the remaining ty failures and the check command's exit-status handling; done means the intended type-check diagnostics are resolved or configured appropriately and make check reports its result correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack: python
Domain: build-system, testing
Issue type: Bug
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Quiet
Clarity: Mostly clear
Newbie friendliness: 48/100