NVIDIA-Merlin / NVIDIA-Merlin/Merlin
[Task] Use pre-commit for linting in GitHub Actions Workflow
Open
@oliverholworthy is already working on this.
Since Dec 15, 2022.
chore
ci
- Dominant language
- Python
- Stars
- 907
- Forks
- 129
- PR merge metrics
- No merged PRs in 30d
Description
Description
We have been using pre-commit in projects for linting in our local commits. However, we've been running checks using a different mechanism in our GitHub actions workflows.
Updating to use pre-commit in a GitHub Actions workflow ensures that the checks we run locally are consistent with the ones we run in CI. Reducing the risk of version discrepancies in CI and Local development.
- Models
https://github.com/NVIDIA-Merlin/models/pull/106 - Dataloader
https://github.com/NVIDIA-Merlin/dataloader/pull/55 - Transformers4Rec
https://github.com/NVIDIA-Merlin/Transformers4Rec/pull/545 - NVTabular
https://github.com/NVIDIA-Merlin/NVTabular/pull/1723 - Core
https://github.com/NVIDIA-Merlin/core/pull/184 - Systems
https://github.com/NVIDIA-Merlin/systems/pull/254 - Merlin
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.