NVIDIA-Merlin / NVIDIA-Merlin/Merlin

[Task] Action items from CI retrospective 2022-08-03

Open
#586 1 comment 0 reactions 2 assignees View on GitHub

@karlhigley is already working on this.

Since Sep 6, 2022.

Dominant language
Python
Stars
907
Forks
129
No merged PRs in 30d

Description

Problem:

Merlin team conducted this 5 why exercise to identify CI related pain points

  • Build issues are found late in the release process
    • Untracked changes to requirements and build processes of these pacakages are introduced ( not clear. discussion tracked here)
    • As part of the release process, issues with upstream dependencies are not tracked
    • RC builds of base container are not being used in the nightly
  • PRs cannot be merged
    • intermitent issue with the CI process
    • Jenkins machine (uses the CI-nightly container) and yet behaves differently ( root cause not established clearly. Discussion tracked here
  • Multi-stage example notebooks are broken
    • PR checks don’t catch downstream issues. We don't currently have a way to run all unit tests when a merge is done at a repo.
      • for instance when we do PR tests on core, we don’t test out that it works with nvt/models/systems (addressed)
      • CI does not run unit test when someone pushes a PR to Systems because unit test is in Merlin repo (addressed)
  • Performance is not tracked in our release process

Goal:

Avoid last minute dependency hell by being proactive and tracking release risk at the start of the development cycle

Constraints:

Sub-tasks:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.