NVIDIA-Merlin / NVIDIA-Merlin/Merlin

[RMP]Merlin Unit tests

Open
#428 3 comments 0 reactions 1 assignee View on GitHub

@bschifferer is already working on this.

Since Jul 4, 2022.

roadmap
Dominant language
Python
Stars
907
Forks
129
PR merge metrics
No merged PRs in 30d

Description

Problem:

The current set of unit tests doesn't cover all examples. Additional examples must be added. We need multiple repo unit tests to run on any given repo commit. This will ensure that the changes in the repo submitted work against the current version of any merlin packages that may depend on it.

Goal:

The goal of this work is to be able to run merlin unit tests from all affected (down stream) repos.

Constraints:

  • Must run committed repo unit tests
  • Must install committed repo
  • Must run downstream repo unit tests to ensure continued functionality.

Starting Point:

  • Create a CI system that runs individual environments per unit test iteration
  • Create job to install committed repo and run needed unit tests
  • hook up CI system to individual repos
  • Ensure jobs for each repo run required downstream unit tests aswell as self
  • Need to be able to report results back to the user

Most of these can be handled with #408

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.