NVIDIA-Merlin / NVIDIA-Merlin/Merlin

[Task] Set up integration tests for Merlin example notebooks

Open
#343 4 comments 0 reactions 3 assignees View on GitHub

@gabrielspmoreira is already working on this.

Since Jul 29, 2022.

Dominant language
Python
Stars
907
Forks
129
PR merge metrics
No merged PRs in 30d

Description

Problem:

  • Currently, we have unit tests that cover partial dataset for the example notebooks. We cannot guarantee that example notebooks will be functional for the full dataset.

Goal:

  • Integration tests that will confirm that example notebooks will be fully functional against the full data set.

Constraints:

  • Previously, framework support for TF, PyT and HCTR was available only in NVTabular. With the recent architectural changes support must be made available in Merlin systems. Currently only TF support is available.

Starting Point:

  • Create support for HugeCTR in Merlin Systems for inference
  • Create support for Pytorch in Merlin Systems for inference
  • Refactor integration tests in NVTabular, to remove all non feature processing.
  • Create e2e example notebook for HugeCTR in merlin repo
  • Create e2e example notebook for Pytorch in merlin repo
  • Create CI for hugectr e2e notebook example in merlin repo
  • Create CI for pytorch e2e notebook example in merlin repo
  • Create jobs to run integration tests on different GPU architectures(?)
  • Create jobs to run integration tests on different multi-GPU architectures(?)
  • Create new system for reporting metrics to ASVDB
  • Refactor integration tests to report captured metrics
  • Setup system to display ASVDB metric (internally)
  • Create DLs for ASVDB notifications - per repo (PIC, SIC, ??)
  • Hook in appropriate DLs for Monitored metrics
All
Merlin Models
Merlin Systems
  • #213
Merlin
  • #214

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.