NVIDIA-Merlin / NVIDIA-Merlin/Merlin

Standardize pre-commit hooks across Merlin libraries

Open
#153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
907
Forks
129
PR merge metrics
No merged PRs in 30d

Description

The pre-commit hooks for Merlin libraries have diverged from each other. See, for example:

It looks like they both/all have good stuff in them, but would be great to come up with a standard config and apply it everywhere (potentially including in a template repo.)

Aha! Link: https://nvaiinfa.aha.io/features/MERLIN-808

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the linked .pre-commit-config.yaml files in the Models and NVTabular repositories first, then identify the other Merlin library configurations and any template repository mentioned by the issue. Define a shared standard that preserves the useful hooks, apply it across the relevant repositories, and verify that each configuration remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, yaml
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.