NVIDIA-ISAAC-ROS / NVIDIA-ISAAC-ROS/isaac_ros_visual_slam

Why wait one second for a transform?

Open
#168 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.5k
Forks
206
PR merge metrics
No merged PRs in 30d

Description

Why not use waitForTransform? What if the transforms are not available for some time. Wouldn't it better to even set this timeout as a param?

https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_visual_slam/blame/abfd06c3c6311f63f646b8adb177e930ffcd9485/isaac_ros_visual_slam/src/impl/visual_slam_impl.cpp#L406

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in isaac_ros_visual_slam/src/impl/visual_slam_impl.cpp at the linked transform-waiting code around line 406. Compare the current one-second wait with waitForTransform and determine how a configurable timeout should behave when transforms are unavailable; done means the waiting behavior matches the agreed requirement and is covered by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
robotics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.