NUKnightLab / NUKnightLab/juxtapose
`showCredits` option entirely useless
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 882
- Forks
- 127
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
Because of this logic
https://github.com/NUKnightLab/juxtapose/blob/c02a4c53b0ab367935467b65eac4a84dac163c52/juxtapose/js/juxtapose.js#L316-L320
which takes place after options are copied into this.options, it doesn't matter whether you pass showCredits in options or not, the only thing that matters is whether or not the images arguments have credit values.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the option handling and the linked logic at juxtapose/js/juxtapose.js#L316-L320, starting with how options are copied into this.options. Confirm the behavior for images with and without credit values and for both showCredits settings; done means the option affects credit display as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100