NUKnightLab / NUKnightLab/juxtapose
use buttons instead of anchors for dropbox buttons
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 882
- Forks
- 127
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
Anchor tags as javascript buttons is seen as abusive (see Accessibility recommendations here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a) However, as styled, swapping in a button element causes the dropbox icon to be misaligned on Safari, so this will need to be fixed
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Dropbox button markup and the styles that position its icon, then reproduce the Safari misalignment described in the issue. Replace the JavaScript-triggering anchors with buttons while preserving the icon alignment and verify the result in Safari.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100