NUKnightLab / NUKnightLab/TimelineJS3

Previous, Next buttons have free-floating focus ring

Open
#854 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Issue Description WCAG Criteria Status Category Example Notes
Previous, Next buttons have free-floating focus ring in Firefox instead of it being around the visible button. QA Identified Keyboard Screenshot 2024-05-07 at 3 33 50 PM Probably related to having zero height & width due to .tl-slidenav-content-container having position: absolute. In Mac Safari it's around the visible button but cut off in places.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the Previous and Next button markup and the .tl-slidenav-content-container styling, starting with the zero-size and position:absolute behavior described in the issue. Reproduce keyboard focus in Firefox and Mac Safari, then verify that the focus ring surrounds the visible button without being cut off.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.