NUKnightLab / NUKnightLab/TimelineJS3

Less error thrown when using Timeline as an ES6 Module

Open
#839 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Version used: 3.9.3

The file throwing the error has only one line, importing the Timeline module:
Screenshot 2023-08-31 at 12 09 02 PM

The following error is thrown when importing the timeline script:
Screenshot 2023-08-31 at 12 06 09 PM

When importing the Timeline as a module I wouldn't expect styles to be loaded as well, since the documentation recommends loading the css separately. Is it possible to remove the less import from this module?

/@knight-lab/timelinejs/src/js/index.js
Screenshot 2023-08-31 at 10 38 35 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with @knight-lab/timelinejs/src/js/index.js, which the issue identifies as importing the Less stylesheet alongside the Timeline module. Check the module entry point and the documentation's separate CSS-loading guidance. Done means importing Timeline as an ES6 module no longer attempts to load styles through that entry point.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.