NUKnightLab / NUKnightLab/TimelineJS3
start and end parameters no longer appear to be working for YouTube videos
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
The documentation for the iframe player API claims support for start and end parameters. Indeed it is believed that this worked at one time (end time implementation was completed as #389). This no longer seems to be the case. The iframes as constructed by the API no longer seem to contain the start and end parameters specified to the YouTube API
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/js/media/types/YouTube.js at the linked line and inspect how the YouTube iframe URL is constructed from the start and end values. Reproduce the issue with a timeline entry using both parameters, then verify that the resulting iframe contains them and that YouTube honors the requested playback range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100