NUKnightLab / NUKnightLab/TimelineJS3

Mobile Height Percentage not working

Open
#675 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Hi Timeline-Team,

the option »mobile_height_percentage« is not always working.
As an example–I call timeline with this options:

var additionalOptions = {
height: 700,
start_at_end: true,
default_bg_color: {r:255, g:255, b:255},
language: 'en',
scale_factor: 4,
timenav_height: 215,
timenav_height_min: 215,
timenav_mobile_height_percentage: 45,
zoom_sequence: [3, 4, 5, 6, 8, 13, 21, 34, 55, 89],
}

But if if load my Site in Google-Chrome with user-device set to »iPhone X« I see that Timeline is rendered with approximately 25% height.
Would be great if the mobile-height would overrule the timenav_height-options.

It would also be nice to have not only percentage but also pixel-width for mobile as an option.

Thanks in advance.
Best.
Christoph.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the supplied options in Google Chrome using iPhone X device emulation, especially the interaction between timenav_mobile_height_percentage and timenav_height. Trace the mobile timeline height calculation and verify that the percentage setting produces the expected height and takes precedence where appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.