NUKnightLab / NUKnightLab/TimelineJS3
Add Width and Height to Image-tags
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
If you perform a Lighthouse-Audit it says, that all images should have explicitly set the width and height attributes.
Please add a possibility to maintain these fields in Timeline.
One approach would be to alter the JSON-File, that users can pass the Width and Height for Media-Files and their thumbnails.
And maybe a fallback would be to automatically calculate these attributes within timeline.js.
The attached screenshots show pseudo-code of possible adjustements.
Thanks in advance.
Best.
Christoph.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review timeline.js and the JSON structure used for media files and thumbnails; the issue proposes supplying width and height there or calculating them automatically. Clarify which approach is intended, then verify that generated image tags include explicit width and height attributes for both media and thumbnails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100