NUKnightLab / NUKnightLab/TimelineJS3
Math error in Cosmological timelines
@JoeGermuska is already working on this.
Since Oct 6, 2020.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
A Zendesk user reported a problem in the display of recent dates on "cosmological" scale timelines.
For example, an event in year 370 is labeled as "370 years ago". Even dates in the future are listed as some number of "years ago"
While we're looking at this, we should consider getting rid of superfluous .0, especially in the time axis, and consider whether we can be friendlier with date formatting for nearer dates, perhaps even switching to BCE/CE, although that has internationalization challenges. But also, math problems aside, rather than "8.0 thousand years ago" we could at least write "8 thousand years ago"; can we do "8000 years ago"? (and what I18N changes does that add?)
a Google sheet demonstrating the issue
Timeline based on that Gsheet
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.