Remove `product-demo` class -> causing overflow on preview embed

Open Beginner friendly

#602 opened on Jan 24, 2019 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug CSS

Dominant language: JavaScript
Stars: 3.2k
Forks: 645
PR merge metrics: No merged PRs in 30d

Description

https://github.com/NUKnightLab/TimelineJS3/blob/d2682545acb7c27e760d6e371cdbd64036b08f45/website/templates/_make.html#L284

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Open website/templates/_make.html at the linked line and inspect the product-demo class in the preview embed markup. Remove the class and verify that the preview embed no longer overflows.

Written by the indexing model from the issue text.

Assessment

Tech stack: javascript
Domain: frontend
Issue type: Bug
Difficulty: 1/5
Estimated time: Under an hour
Activity status: Stale
Clarity: Clearly specified
Newbie friendliness: 62/100

A short digest of beginner-friendly GitHub issues.