NUKnightLab / NUKnightLab/TimelineJS3

Error in handling big negative dates together with small positives

Open
#578 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Hi guys,

I try to display really big negative dates (e.g 14 billion years BC) and normal dates (e.g. 2018 AD) in a single timeline, but the latter is always treated as a negative date (i.e. 2018 BC instead of AD)

It is very easy to reproduce, I'm using the original sample, so there are no other tricks in the spreadsheet
https://docs.google.com/spreadsheets/d/1JGtBV78aKH-r7KbzRwnksLXhk3htue02a2JhKSSCyV4/edit#gid=0

https://cdn.knightlab.com/libs/timeline3/latest/embed/index.html?source=1JGtBV78aKH-r7KbzRwnksLXhk3htue02a2JhKSSCyV4&font=Default&lang=en&initial_zoom=2&height=650

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Google Sheets sample and TimelineJS embed to reproduce the mixed-date timeline: a very large negative date causes 2018 AD to render as 2018 BC. Trace the date handling used by the timeline display, then verify that negative and positive dates retain their correct eras in the reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.