NUKnightLab / NUKnightLab/TimelineJS3

Media should be vertically centered.

Open
#526 1 comment 0 reactions 1 assignee View on GitHub

@rosaliechan is already working on this.

Since May 22, 2017.

CSS
Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Summary

Currently .tl-media is top aligned, even though .tl-text is centered using display: table-cell and vertical-align: middle. It even looks like someone was considering this in TL.media.less.

There would also have to be a media query to have this only apply on non mobile/small displays.

Example

Top Align (Currently)
Vertically Centered

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.