NUKnightLab / NUKnightLab/TimelineJS3

Improving Hash Bookmarks

Open
#382 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

In regards to the Hash Bookmarks setting:

Add hash bookmarks
On each slide, a # will be added to the end of the url in the url bar. These urls are bookmarkable, so you can share or return to the same place in the timeline later.

This is very helpful, but there are two things that are preventing me from using this feature:

1) Eliminating the "Hash" for the first "default" slide.
I do not believe this should be happening on the first slide. That is not useful for those placing the timeline in a block on a page that isn't completely dedicated to the timeline. Reason: the link to the page that embeds the timeline is "always" the link to the default (First or Last) slide.

2) Scroll to timeline if hash link is accessed.
I have a very long page with a timeline at the bottom. If the hash bookmarks are intended to bring people to a particular slide, this feature is meaningless in my use case.

Thank you in advance and hoping this gets some attention.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Hash Bookmarks implementation and reproducing the behavior for the first or default slide and for a timeline embedded near the bottom of a long page. Done means the default slide does not add an unnecessary hash, while a hash link scrolls the page to the timeline and opens the requested slide.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.