NUKnightLab / NUKnightLab/TimelineJS3
No hash update when using goToPrev/goToNext
Open
Nobody has claimed this yet.
Enhancement
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Fixed it with:
// Goto previous slide
goToPrev: function() {
this.goTo(this._getSlideIndex(this.current_id) - 1);
/* BUG FIX : next 3 lines */
if (this.options.hash_bookmark && this.current_id) {
this._updateHashBookmark(this.current_id);
}
},
// Goto next slide
goToNext: function() {
this.goTo(this._getSlideIndex(this.current_id) + 1);
/* BUG FIX : next 3 lines */
if (this.options.hash_bookmark && this.current_id) {
this._updateHashBookmark(this.current_id);
}
},
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the goToPrev and goToNext entry points and inspect how hash_bookmark and _updateHashBookmark are handled around navigation. Verify that navigating in either direction updates the URL bookmark when hash bookmarking is enabled, without changing behavior when it is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100