NUKnightLab / NUKnightLab/TimelineJS3
Google Plus embeds don't work.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
A Zendesk user reported Google Plus links not embedding. Console inspection revealed:
Refused to display 'https://plus.google.com/+…/posts/… in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.
We need to investigate whether we can update our embed strategy. It looks like Google's preferred option includes loading javascript from them that transforms their base embed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing embed handling for Google Plus links and reviewing Google's preferred JavaScript-based embed approach. Confirm whether the strategy can avoid the X-Frame-Options error, and consider the issue done when Google Plus links render correctly in the timeline.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100