NUKnightLab / NUKnightLab/TimelineJS3
Move ensureValidScale into TimelineConfig.validate
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Issue was made evident by user who had "???" in the year column which caught the invalid_year_err in TL.BigYear.
Link to spreadsheet: https://docs.google.com/spreadsheets/u/1/d/1Hm79KVcUQOF9N3Mt-iYd5GXHx8WsYh1NZazUIAkKnow/pubhtml
Before, these slides just wouldn't show and users may not have noticed, but with current stricter validation, it shows an error instead of an incomplete or broken Timeline.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ensureValidScale and TimelineConfig.validate, then trace how invalid_year_err is raised for TL.BigYear. Use the linked spreadsheet as the reproduction case and confirm that moving the validation produces a complete, correctly handled Timeline instead of an error or missing slides.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100