NUKnightLab / NUKnightLab/TimelineJS3
Hash/bookmarks don't work with iframes
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Task 1: remove that from the "authoring tool" (or possibly add clarification/link to FAQ?)
Task 2: investigate window message passing to see if there's a way to do this safely. I read about that some over the weekend, and I'm not really sure how we would. So maybe we can't do it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the authoring tool behavior around hash/bookmark links in iframes, then investigate the window message-passing entry points mentioned in the issue. Clarify whether the authoring tool should remove or document the behavior, and determine whether safe message passing can support it; the issue is done when one of those outcomes is specified and implemented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100