NUKnightLab / NUKnightLab/TimelineJS3

Implement hashchange events

Open
#278 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Hi, first of all i just want to tell that i am not web developer i just like to experiment and learn new things so sorry if this is trivial question. I started working on small project in my free time and i worked with 2.x version for some time. Now that 3.x version is here i want to use it for several reasons. But now i have issue that i had with 2.x (friend helped me to solve it in 2.x). Issue is that links in drop down menu (separate JQuery element on page) wont go to slide. In 2.x solution was simple i just changed is_moving from false to true (in timeline-min.js) and links worked without issue. But in 3.x now i don't know what to do.

What can you recommend me to try to solve this issue? (I would ask my friend but he is really busy now and in the end you know this code better). Thank you in advance.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining timeline-min.js and the existing 3.x navigation behavior described in the issue. Determine how dropdown links are expected to navigate to slides and whether hash changes should trigger that navigation; done means those links work in 3.x without the 2.x is_moving workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.