NUKnightLab / NUKnightLab/TimelineJS3
Group layout doesn't account for marker_min_heigt
Open
Nobody has claimed this yet.
Bug
Time axis layout: markers and groups
- Dominant language
- JavaScript
- Stars
- 3.2k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Special case related to #259: group rows don't take marker_height_min into account. See this test timeline
With marker_height_min set to 60, the markers overflow the group rows:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked test timeline and reproduce the layout using marker_height_min=60, comparing group row sizing with the overflowing markers shown in the issue. Trace the group layout calculation and verify that rows account for the minimum marker height; done means markers no longer overflow their group rows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100