NUKnightLab / NUKnightLab/TimelineJS3

support HTML5 audio/video tags

Open
#228 2 comments 0 reactions 1 assignee View on GitHub

@zachwise is already working on this.

Since Sep 17, 2015.

Enhancement Feature Proposal
Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Zach:

It seems functionally easy to support audio and video tags using the iframe media type.

Would you be cool with adding that to the pattern for that media type? Do you think some other presentation/styling is necessary? Is it worth adding a new media type just to support a different CSS class other than tl-media-iframe ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.