NUKnightLab / NUKnightLab/TimelineJS3

FR: support left/right swap of media and text regions

Open
#164 2 comments 0 reactions 1 assignee View on GitHub

@zachwise is already working on this.

Since Aug 1, 2015.

Enhancement Feature Proposal
Dominant language
JavaScript
Stars
3.2k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

I have created a modified version of timelineJS that allows for indicating an alignment option on a per event basis, basically in the JSON you indicate "align": "right" to swap the image and content alignment, "align": "center" to center and stack the image and content, or "align": "left" to have the original functionality of image on left, text on right. You can see an example of this here: http://rlacy.tidalwaveagency.com/index.php/history

My current implementation was quick and dirty as we needed to demo the functionality for a client, but I thought I would pitch the idea up and see if there was any interest. If there is, I would be happy to implement it properly via your build system and submit a PR. I have not fully vetted any edge cases but it was a relatively simple modification with only a few modifications to the JS and some new CSS classes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.