NUKnightLab / NUKnightLab/StoryMapJS
Remove or update CSS zoom property
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Via Zendesk, we received this request:
as Firefox warns, please change the css »zoom:1« to «transform:scale(1);transform-origin: 0 0«
zoom is not a standard CSS property, so this change should be made.
All references to the zoom property seem caught up in very old IE support, and in some cases, use "the star hack". They should probably simply be removed rather than updated to use transform
https://github.com/NUKnightLab/StoryMapJS/blob/34d8150c1743ea9f86820e687cb485a0e67111c5/source/less/map/leaflet/VCO.Leaflet.IE.less#L31
https://github.com/NUKnightLab/StoryMapJS/blob/34d8150c1743ea9f86820e687cb485a0e67111c5/source/less/core/Mixins.less#L117
https://github.com/NUKnightLab/StoryMapJS/blob/34d8150c1743ea9f86820e687cb485a0e67111c5/source/less/core/Reset.less#L46
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the three referenced LESS files: source/less/map/leaflet/VCO.Leaflet.IE.less, source/less/core/Mixins.less, and source/less/core/Reset.less. Review each zoom declaration and its surrounding IE-specific logic, then remove obsolete references or update them as appropriate; verify the generated styles no longer produce Firefox warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100