NUKnightLab / NUKnightLab/StoryMapJS
bad lat/lon specifications causing editor hangups
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Users who are interpreting the helper text to mean that their lat/lon values should be enclosed in angle brackets <>, are having editor hangups due to the inability to interpret the resulting bracketed values.
In general, we should probably clean out non-numeric characters when we parse lat/lon from the input here https://github.com/NUKnightLab/StoryMapJS/blob/master/templates/edit.html#L1621
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at templates/edit.html around line 1621 and reproduce the editor hangup with latitude and longitude values enclosed in angle brackets. Check how the input is parsed and verify that bracketed values no longer prevent the editor from interpreting the coordinates. Done means the reported input is handled without an editor hangup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100