Use Custom Marker Error

Open

#405 opened on Aug 16, 2018 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: JavaScript
Stars: 248
Forks: 61
Avg merge: 1m
Merged PRs (30d): 1

Description

From the StoryMap ReadMe:

"Images can now be used in place of map pins. Use image inside the location object and include a url to use. use_custom_markers also has to be set to true in the story map options. Same goes for custom icons except you need icon inside the location object and include a url to use."

The slide->location->image property is not working; slide->location->icon IS working. When requesting a custom image in place of map pins, the following error is thrown, with the following stack trace:

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with the StoryMap ReadMe's custom marker example and reproduce the failure using a location image with use_custom_markers enabled. Trace the _createImage and _createMarker paths from the reported stack trace; the work is done when custom images render without the ReferenceError and existing custom icons still work.

Written by the indexing model from the issue text.

Assessment

Tech stack: javascript
Domain: frontend, web-dev
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 30/100