NUKnightLab / NUKnightLab/StoryMapJS
Styles on "code" make list formatting weird
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
This was introduced in #309 to prevent long URLs from being broken in the "Help" section of https://storymap.knightlab.com/#help, under "How can I link to a specific slide?".
There are two problems here:
- That stylesheet isn't loaded on https://storymap.knightlab.com/#help (and in Chrome 59 on OSX, the issue described in #309 doesn't appear to exist, making the styles there unnecessary in the current form of this repo)
- The
display: blockrule breaks inline formatting of code elements in https://storymap.knightlab.com/advanced/:
Here's the "Advanced" page with code { display: block; }:
And without:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with static/css/site.css at lines 28-29 and compare the Advanced page with and without the code styles. Check the Help section and the linked issue #309 to understand whether the long-URL behavior still needs these rules. Done means inline code formatting works on the Advanced page without reintroducing the reported Help-page problem.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100