NUKnightLab / NUKnightLab/StoryMapJS
null style attribute
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
A StoryMap (unable to share link) had this error:
which traces to VCO.Media.js 115-117
We should make sure this exception doesn't happen, by better guarding the instantiation of the objects so that style is never null and/or testing before setting it in this code (and probably many analogous lines)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/js/media/VCO.Media.js at lines 115-117 and inspect how the StoryMap media objects are instantiated before style is accessed. Reproduce the linked null-style failure if possible, then verify that a StoryMap with missing style data no longer throws and review analogous lines for the same exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100