NUKnightLab / NUKnightLab/StoryMapJS
Uneditable editor state caused by cancelling out of storymap list modal
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
The introduction of a cancel button on the storymap list modal in dfd04a4af32f07d712396482301f6a528f68a053 resulted in canceling out into an editor state where there is no associated storymap. This causes confusing UX as it may not be clear why the editor is in this state or how to get to the proper state.
The cancel button is currently commented out in templates/select.html. The fix will require that cancelling exists to the currently selected map (if one is currently selected). In the case that no map is selected, the bad editor state should be prevented by forced map selection/creation, or by disabling the cancel button.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in templates/select.html, where the cancel button is currently commented out, and reproduce cancelling from the storymap list modal with and without a selected map. Trace how the editor state changes during that flow. Done means cancelling returns to the selected map, or prevents the invalid no-map editor state through selection, creation, or a disabled cancel action.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100