NUKnightLab / NUKnightLab/StoryMapJS
map_as_image zoom issue
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Wanted to document the issue that was being discussed in Slack...
A user's StoryMap worked in Safari but not Chrome (navigating to the second or third slide causes Chrome to lock up). Changing the value of map_as_image from true to false prevents the issue.
When map_as_image is true, calculate_zoom is set to false. If I let StoryMap calculate the zoom (instead of taking it from the JSON data), everything is fine. So this is definitely related to a user-specified zoom. However, I don't know enough about the innards of Leaflet to figure out what the exact issue is.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by reproducing the Chrome lock-up on the second or third slide with map_as_image set to true and a user-specified zoom, then compare it with map_as_image false or calculate_zoom enabled. Done means the StoryMap no longer locks up in Chrome while preserving the intended zoom behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100