NUKnightLab / NUKnightLab/StoryMapJS

review URL protocols

Open
#246 2 comments 0 reactions 1 assignee View on GitHub

@JoeGermuska is already working on this.

Since Jun 29, 2015.

bug ready to test
Dominant language
JavaScript
Stars
248
Forks
61
Avg merge
1m
Merged PRs (30d)
1

Description

Someone pointed out that the Vimeo player URL was http, which doesn't work with HTTPS sites. This is fixed in 2f5a714 but I think there are other cases (open street map tiles? maybe others)

Someone needs to go through the code and make sure we use protocol relative URLs wherever we can.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.