NUKnightLab / NUKnightLab/StoryMapJS
Image scaling off on Firefox
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 248
- Forks
- 61
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
A Zendesk support ticket reported cross-browser issues with image sizing.
The example site is http://www.modernevansville.com/downtown-tour/ on Firefox, Images are getting a max-width property that makes them look puny.
Maybe to do with https://github.com/NUKnightLab/StoryMapJS/blob/master/source/js/media/VCO.Media.js#L112-L117 and also the fact that the page layout is compressing the width of the StoryMap.
It looks better loaded directly at http://s3.amazonaws.com/cdn.knightlab.com/libs/storymapjs/latest/embed/index.html?url=https://www.googledrive.com/host/0B0nyc06wkxX9SkJkZWhZakRSR2s/published.json
Is there anything to be done?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with source/js/media/VCO.Media.js lines 112-117 and reproduce the image sizing on the linked Firefox example site. Compare it with the direct StoryMap embed, then verify that images no longer receive an overly restrictive max-width and that the compressed StoryMap layout displays them correctly in Firefox.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100