can we generalize speckle` _process` so that bincount can be used on floats?
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
See the issue below, as they are related, but this is to address a specific question of
np.histogram versus np.bincount raised in
https://github.com/NSLS-II/pyCHX/issues/52
np.histogram is used for image based data because image normalization process creates floats (this is the case for csxtools get_fccd_images()). Some discussion of the various options would be good. Please add other options if I have missed one. We can consider multiple approaches too, but probably need to prioritize
- have 2 _process subfunctions: one for integer data (like Eiger detector) and one for float data
- convert floats to integers in a way that we agree.
- require input (whether images (aka full np.array) or compressed data) must be integers
@danielballan and others?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading linked issue #52 and locating the _process subfunctions that use np.histogram or np.bincount. Compare the three proposed approaches for integer and float image data, then confirm the chosen behavior and scope with maintainers. Done means the agreed approach is implemented and its behavior for image and compressed data is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100