NSLS2 / NSLS2/pyCHX

questions about results file created by pyCHX

Open
#63 0 comments 0 reactions 3 assignees View on GitHub

@xmchenGH is already working on this.

Since Feb 16, 2021.

question
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

Just a list of questions that we can add to and answer:

  • What is the units of md['dectector_distance']? The values is 16075.637817382812

  • What is qth_interest? It is an integer, so is it the number of rois?

  • Seems there are some redundant md key values in the md dictionary. Are they all needed?
    Measurement versus sample
    shutter_mode versus shutter mode
    beg versus beg_OneTime versus good_start
    end versus end_OneTime
    all the keys bringing with eiger4m.... for beam center and acquisition details and incident wavelength and so on
    acquire_period versus frame_time

  • is md['time'] the time that the notebook was executed or results data is save to file?

  • md[qr] is the same as qval_dict, except qval_dict is an unordered dictionary. Are both needed? Can we live with getting rid of one of these, and are there strong arguments for either @AbbyGi @xmchenGH this is important for NeXus file.

This may also be useful for @AbbyGi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.